[PATCH] D105263: [X86] AVX512FP16 instructions enabling 1/6

Simon Pilgrim via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Jul 2 06:23:28 PDT 2021


RKSimon added inline comments.


================
Comment at: clang/lib/Headers/avx512fp16intrin.h:38
+
+static __inline__ _Float16 __DEFAULT_FN_ATTRS512 _mm512_cvtsh_h(__m512h __a) {
+  return __a[0];
----------------
I realize its a lot of work, but is there any chance that we could get doxygen comments to document these intrinsics?


================
Comment at: llvm/lib/Target/X86/X86Subtarget.h:748
   bool hasVLX() const { return HasVLX; }
+  bool hasFP16() const { return HasFP16; }
   bool hasPKU() const { return HasPKU; }
----------------
I'm a little worried this might get confused with hasF16C - am I just being over cautious?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105263/new/

https://reviews.llvm.org/D105263



More information about the cfe-commits mailing list