[PATCH] D100553: [clangd] Log feature configuration (linux+asan+grpc) of the clangd build

Fri Jul 2 01:07:27 PDT 2021

sammccall added a comment.

In D100553#2852981 <https://reviews.llvm.org/D100553#2852981>, @thakis wrote:

> I guess now clangd/xpc needs an explicit dep on that .inc generating rule.

I think it's rather missing `-I` for the generated clangd directory.
(The targets in clangd/xpc depend on clangDaemon which requires that generated header - not wonderfully explicit but also seems to be the way this is usually done at least in CMake)

> Tried again in 2f79acb7b701c41494abff588b5f03a74ea2e11d <https://reviews.llvm.org/rG2f79acb7b701c41494abff588b5f03a74ea2e11d>. If someone wants to figure out how to make xpc see Features.inc in the cmake build, that'd work too.

Sorry, there was a near-identical break in index/remote/ and I didn't spot the xpc variant.
The idea is that all files under clang-tools-extra/clangd/ should have clangd/ on the include path (both normal and generated files).

Landed a few patches trying to improve this:

- 86c5afa6e601c4a80d46a7a8b892d5c49bcec078 <https://reviews.llvm.org/rG86c5afa6e601c4a80d46a7a8b892d5c49bcec078> is the missing include from your log
- 0c53f602d5a9d7207abb13e463f68e9d092f47a7 <https://reviews.llvm.org/rG0c53f602d5a9d7207abb13e463f68e9d092f47a7> is a few more cases i found
- then 26e1553a107f52667be879e99739a4153f8799d8 <https://reviews.llvm.org/rG26e1553a107f52667be879e99739a4153f8799d8> just adds the include dirs at the top level (where it's not needed!) since cmake seems to inherit this property to subdirectories

Not sure if these changes are things the gn bot is usually able to sync automatically, but at least CMake should be good and less fragile now, and check-clangd is still passing on the gn bots. I think 2f79acb7b701c41494abff588b5f03a74ea2e11d <https://reviews.llvm.org/rG2f79acb7b701c41494abff588b5f03a74ea2e11d> is now unneccesary (at least for cmake) and may try to revert it, but probably rather on monday than break more things today...

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100553/new/

https://reviews.llvm.org/D100553