[PATCH] D105287: Fix an accepts-invalid issue with [[]] attributes in the type position in C

Erich Keane via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Jul 1 07:59:14 PDT 2021


erichkeane added a comment.

I guess I don't see how this patch 'works' here.  I don't see anything preventing the type-location in C, but not C++?



================
Comment at: clang/test/Sema/attr-c2x.c:14
 
-void foo(void *c) [[clang::overloadable]];
-void foo(char *c) [[clang::overloadable]];
+[[clang::overloadable]] void foo(void *c);
+[[clang::overloadable]] void foo(char *c);
----------------
Do we have a test to validate that the previous syntax isn't allowed?  I don't see any being added, but I might be missing it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105287/new/

https://reviews.llvm.org/D105287



More information about the cfe-commits mailing list