[PATCH] D105091: [RISCV] Pass -u to linker correctly.

Fangrui Song via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Jun 30 12:36:34 PDT 2021


MaskRay requested changes to this revision.
MaskRay added a comment.
This revision now requires changes to proceed.

> -u is a linker option used to pretend a symbol is undefined, this option are common used for force pull-in weak symbol.

for forcing archive member extraction.

weak symbols are somewhat orthogonal.



================
Comment at: clang/test/Driver/riscv-args.c:5
 // RUN: %clang -### -target riscv32 \
 // RUN:   --gcc-toolchain= -Xlinker --defsym=FOO=10 -T a.lds %s 2>&1 \
 // RUN:   | FileCheck -check-prefix=CHECK-LD %s
----------------
Just place all linker options on one run line.

It decreases the number of RUN lines and additionally checks the order (though usually unimportant).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105091/new/

https://reviews.llvm.org/D105091



More information about the cfe-commits mailing list