[PATCH] D105221: [openmp][nfc] Simplify macros guarding math complex headers

Jon Chesterfield via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Jun 30 11:53:53 PDT 2021


JonChesterfield added a reviewer: ronlieb.
JonChesterfield added a comment.

this unblocks the hazard I am concerned about for D104904 <https://reviews.llvm.org/D104904>, namely it stops us defining `__CUDA__` when compiling amdgcn code that includes complex.h



================
Comment at: clang/lib/Headers/__clang_cuda_complex_builtins.h:21
 #pragma omp declare target
 #define __DEVICE__ __attribute__((noinline, nothrow, cold, weak))
 #else
----------------
bit weird that these are weak, but not changing that here


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105221/new/

https://reviews.llvm.org/D105221



More information about the cfe-commits mailing list