[PATCH] D104904: [OpenMP][AMDGCN] Initial math headers support

[Jon Chesterfield via Phabricator via cfe-commits]

JonChesterfield added inline comments.


================
Comment at: clang/lib/Headers/openmp_wrappers/math.h:41
 #pragma omp begin declare variant match(                                       \
     device = {arch(nvptx, nvptx64)}, implementation = {extension(match_any)})
 
----------------
tianshilei1992 wrote:
> JonChesterfield wrote:
> > @jdoerfert do you know why we have match_any here? wondering if the amdgcn variant below should have the same
> Because `nvptx` and `nvptx64` share the same implementation. They just emit different IRs. If AMDGCN only has one architecture, it doesn't need to use `match_any`.
ah, right - thank you!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104904/new/

https://reviews.llvm.org/D104904