[PATCH] D104904: [OpenMP][AMDGCN] Initial math headers support

Lieberman, Ron via cfe-commits cfe-commits at lists.llvm.org
Wed Jun 30 09:57:02 PDT 2021


[AMD Official Use Only]

It maybe that the patch does not expose __CUDA__ directly.
Rather the patch works so well we finally see the pre-existing issue in complex.h

./clang/lib/Headers/openmp_wrappers/complex.h

-----Original Message-----
From: Jon Chesterfield via Phabricator <reviews at reviews.llvm.org> 
Sent: Wednesday, June 30, 2021 12:33 PM
To: Singh, Pushpinder <Pushpinder.Singh at amd.com>; jonathanchesterfield at gmail.com; xw111luoye at gmail.com; Lieberman, Ron <Ron.Lieberman at amd.com>; greg63706 at gmail.com; jdoerfert at anl.gov; Liu, Yaxun (Sam) <Yaxun.Liu at amd.com>; Chan, SiuChi <siuchi.chan at amd.com>; Sumner, Brian <Brian.Sumner at amd.com>; jhuber6 at vols.utk.edu; tianshilei1992 at gmail.com
Cc: Shi, Aaron En Ye <Aaronenye.Shi at amd.com>; estewart08 at gmail.com; stefomeister at gmail.com; cfe-commits at lists.llvm.org; jv356 at scarletmail.rutgers.edu; zhang.guansong at gmail.com; Kumar N, Bhuvanendra <Bhuvanendra.KumarN at amd.com>; mlekena at skidmore.edu; blitzrakete at gmail.com; shenhan at google.com; tra at google.com; kuhnel at google.com
Subject: [PATCH] D104904: [OpenMP][AMDGCN] Initial math headers support

[CAUTION: External Email]

JonChesterfield added a comment.

@ronlieb reports that this change means __CUDA__ is defined for openmp amdgcn compilation. I'm going to try to verify that


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Freviews.llvm.org%2FD104904%2Fnew%2F&data=04%7C01%7Cron.lieberman%40amd.com%7C30a5efe76bea490b3ca008d93be4a84d%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637606675525170968%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=G75Ey7JiNVDx74nF6x0VeCazDx6nngKoYzufecJdCok%3D&reserved=0

https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Freviews.llvm.org%2FD104904&data=04%7C01%7Cron.lieberman%40amd.com%7C30a5efe76bea490b3ca008d93be4a84d%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637606675525170968%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=LSZRpI6r4KqgKR5ZREXDlLH5kJPUJr20vgK79wC0dCU%3D&reserved=0


More information about the cfe-commits mailing list