[PATCH] D93525: [clang-offload-bundler] Add unbundling of archives containing bundled object files into device specific archives
George Rokos via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed Jun 30 07:46:01 PDT 2021
grokos added inline comments.
================
Comment at: clang/tools/clang-offload-bundler/ClangOffloadBundler.cpp:147
+ Target.split(Components, '-', 5);
+ Components.resize(6);
+ this->OffloadKind = Components[0];
----------------
saiislam wrote:
> grokos wrote:
> > Leftover? `Components` is already 6 elements long.
> Not necessarily. It is possible that target has less than 6 elements. For example all bundling/unbundling cases which do not require GPUArch field.
> E.g. "openmp-powerpc64le-ibm-linux-gnu"
OK, thanks!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D93525/new/
https://reviews.llvm.org/D93525
More information about the cfe-commits
mailing list