[PATCH] D105185: [AIX] Add _AIX73 version macro

Jake Egan via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Jun 30 06:58:46 PDT 2021


Jake-Egan added inline comments.


================
Comment at: clang/lib/Basic/Targets/OSTargets.h:704
+    if (OsVersion >= std::make_pair(7, 3))
+      Builder.defineMacro("_AIX73");
 
----------------
xgupta wrote:
> Jake-Egan wrote:
> > xgupta wrote:
> > > Seems this line need formatting?
> > I originally had it matching the format of the other _AIX macro definitions, but clang-format modified it to this.
> I think clang-format is there to maintain consistency in the codebase. You can ignore it if it is doing the opposite.
Do you suggest that I revise the formatting then?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105185/new/

https://reviews.llvm.org/D105185



More information about the cfe-commits mailing list