[PATCH] D105167: [analyzer] Fix HTML report deduplication.

Balázs Benics via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Jun 30 05:42:55 PDT 2021


steakhal added a comment.

AFAIK from CodeChecker's side we are fine with this change. I think we are not using the `stable-report-filename` analyzer config either.
Aside from these, the less //Perl// the better, I guess.



================
Comment at: clang/lib/StaticAnalyzer/Core/HTMLDiagnostics.cpp:277
+
+  std::stringstream filename;
+  filename << "report-";
----------------
I don't frequently see `stringstream`s in the codebase.
Why don't you use the llvm alternative?
```
std::string s;
llvm::raw_string_ostream os(s);
```


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105167/new/

https://reviews.llvm.org/D105167



More information about the cfe-commits mailing list