[PATCH] D104052: [clang] Fix CallExpr dependence bit may not respecting all its arguments.

[Haojian Wu via Phabricator via cfe-commits]

hokein added a comment.

sorry for the delay, I lost the track.

> I think I can also live with adding explicit recomputeDependence() calls in the right places, and slapping a warning on setArg() that it might be needed.

I'm inclined with this option.

As you mentioned,  there are two major places (ConvertArgumentForCall and BuildResolvedCallExpr in SemaExpr)  calling `setArg`, and it is trivial to update them. 
There are a lot of `setArg` usage in `SemaChecking.cpp`, but I think we're not interested to them --  because there are invalid checks before calling `setArg` and we mostly care about the error-bit.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104052/new/

https://reviews.llvm.org/D104052