[PATCH] D104285: [analyzer] Retrieve value by direct index from list initialization of constant array declaration.

Tue Jun 29 16:41:48 PDT 2021

chrish_ericsson_atx added a comment.

In D104285#2847547 <https://reviews.llvm.org/D104285#2847547>, @ASDenysPetrov wrote:

> I don't think we should revert b30521c28a4d <https://reviews.llvm.org/rGb30521c28a4dc1b94d793385e4144ede5822b2c1> because it corrects symbol representation in CSA and fixes two bugs: https://bugs.llvm.org/show_bug.cgi?id=37503 and https://bugs.llvm.org/show_bug.cgi?id=49007. Another point of non-revert is that your cases were previously hidden in CSA core and that's good to find them. I'm afraid it's a dubious idea to return back old bugs in favor of not seeing new ones.

Valid point.  Thanks for considering the question.  I agree it's better to move forward and get this patch working.  :)   I just wish I had the bandwidth to help more...

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104285/new/

https://reviews.llvm.org/D104285