[PATCH] D104388: [clang-format] PR50727 C# Invoke Lamda Expression indentation incorrect

Marek Kurdej via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Jun 29 13:04:41 PDT 2021


curdeius added a comment.

I can't help with C# part either, unfortunately.
I'll chime in if I see something strange, but current patch looks okay to me. I let other reviewers (@exv) accept it when they feel it's ok.



================
Comment at: clang/lib/Format/UnwrappedLineParser.cpp:1793
   // FIXME: Once we have an expression parser in the UnwrappedLineParser,
   // replace this by using parseAssigmentExpression() inside.
   do {
----------------
Unrelated nit: typo in parseAssignment.


================
Comment at: clang/lib/Format/UnwrappedLineParser.cpp:1797
+      // Fat arrows (=>) have tok::TokenKind tok::equal but TokenType
+      // TT_FatArrow. The always start an expression or a child block if
+      // followed by a curly.
----------------
"The*y* always"... ?


================
Comment at: clang/lib/Format/UnwrappedLineParser.cpp:1798
+      // TT_FatArrow. The always start an expression or a child block if
+      // followed by a curly.
       if (FormatTok->is(TT_FatArrow)) {
----------------
curly brace?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104388/new/

https://reviews.llvm.org/D104388



More information about the cfe-commits mailing list