[PATCH] D105097: [clang][AArch64][SVE] Handle PRValue under VLAT <-> VLST cast
Eli Friedman via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Tue Jun 29 12:01:20 PDT 2021
efriedma added inline comments.
================
Comment at: clang/lib/CodeGen/CGExprScalar.cpp:2120
+ } else
+ Addr = EmitLValue(E).getAddress(CGF);
Addr = Builder.CreateElementBitCast(Addr, CGF.ConvertTypeForMem(DestTy));
----------------
I don't think it's legal to use EmitLValue here at all; the emitted IR could have side-effects.
Since we have the vector insert/extract intrinsics now, can we just use them here instead of going through the load/store dance?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D105097/new/
https://reviews.llvm.org/D105097
More information about the cfe-commits
mailing list