[PATCH] D105017: [analyzer] LValueToRValueBitCasts should evaluate to an r-value

[Balázs Benics via Phabricator via cfe-commits]

steakhal added inline comments.


================
Comment at: clang/lib/StaticAnalyzer/Core/ExprEngineC.cpp:543
       case CK_VectorSplat: {
         state = handleLVectorSplat(state, LCtx, CastE, Bldr, Pred);
         continue;
----------------
NoQ wrote:
> You didn't start it but that's, ugh, not a great name for the function to handle the new cast.
> 
> I wouldn't mind eliminating the function entirely and inlining the implementation as it actually makes the code easier to read, for once.
I'm going to do that in an NFC follow-up patch.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105017/new/

https://reviews.llvm.org/D105017