[PATCH] D103615: [Clang] Add option to handle behaviour of vector bool/vector pixel.

Bardia Mahjour via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Jun 29 07:28:05 PDT 2021


bmahjour added a comment.

In D103615#2846245 <https://reviews.llvm.org/D103615#2846245>, @dblaikie wrote:

> As mentioned in the reverting commit - these tests fail in non-asserts builds, because they assume named IR instructions (like the named entry BB label), which aren't provided on a non-asserts build (there's a flag to turn them on - but that's probably not the right fix - making the test resilient to non-asserts IR is probably the right fix).
>
> Leaving non-asserts builds broken for 12 hours (maybe I'm the first one to come across/report it - but I'd expect there are some buildbots that would fail, etc) is quite a while - best to be avoided when possible.

This is a bit off topic, but I'm just curious about clang's rationale for producing different IR depending on whether asserts are on/off? Seems strange and undesirable to me.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103615/new/

https://reviews.llvm.org/D103615



More information about the cfe-commits mailing list