[PATCH] D103615: [Clang] Add option to handle behaviour of vector bool/vector pixel.

Mon Jun 28 23:05:44 PDT 2021

dblaikie added a comment.

In D103615#2846251 <https://reviews.llvm.org/D103615#2846251>, @dyung wrote:

> In D103615#2846245 <https://reviews.llvm.org/D103615#2846245>, @dblaikie wrote:
>
>> As mentioned in the reverting commit - these tests fail in non-asserts builds, because they assume named IR instructions (like the named entry BB label), which aren't provided on a non-asserts build (there's a flag to turn them on - but that's probably not the right fix - making the test resilient to non-asserts IR is probably the right fix).
>>
>> Leaving non-asserts builds broken for 12 hours (maybe I'm the first one to come across/report it - but I'd expect there are some buildbots that would fail, etc) is quite a while - best to be avoided when possible.
>
> Our internal bot also caught it and I was readying a patch to add "REQUIRES: asserts" to the tests as a workaround.

Thanks for the confirmation! Yeah, I probably could've/should've settled for that narrower solution - good to keep in mind for next time.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103615/new/

https://reviews.llvm.org/D103615