[PATCH] D105066: [Coroutines] Remove CoroElide from O0 pipeline

Xun Li via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Jun 28 18:57:52 PDT 2021


lxfind added a comment.

In D105066#2845958 <https://reviews.llvm.org/D105066#2845958>, @ChuanqiXu wrote:

> On O0, it is possible to inline if the user marked the function with `always_inline`.
> Since CoroElide is kind of optimization, it should be OK to skip in O0.
> Out of curiosity, what's the reason that you want to remove it?

Coroutine functions cannot be inlined before splitting, even if it's marked "always_inline" (in fact, we should make it illegal to mark a coroutine "always_inline", because there is no guarantee that a coroutine can be fully inlined, GCC does that).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105066/new/

https://reviews.llvm.org/D105066



More information about the cfe-commits mailing list