[PATCH] D104963: [ODR] Fix using uninitialized FunctionTypeBits.FastTypeQuals in FunctionNoProtoType.

[Volodymyr Sapsai via Phabricator via cfe-commits]

vsapsai added a comment.

Wasn't actually able to make the test fail because Memory Sanitizer isn't supported on macOS and on Linux I cannot even build clang with MSAN enabled. The test case is reduced from an actual error we've seen internally when clang complaints `Handler` has different definitions in different modules. That was happening because due to uninitialized FastTypeQuals ODR-hash for different modules //sometimes// was different. It is a spurious error and I don't see how to create a reliable test case.

Also I don't know if we should keep FastTypeQuals in FunctionTypeBitfields or move somewhere else. Looks like it is there for a reason, so I've decided not to touch that.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104963/new/

https://reviews.llvm.org/D104963