[PATCH] D104904: [OpenMP][AMDGCN] Initial math headers support

[Shilei Tian via Phabricator via cfe-commits]

tianshilei1992 added a comment.

Those changes in OpenMP headers LGTM, except `#define __device__`.



================
Comment at: clang/lib/Headers/openmp_wrappers/__clang_openmp_device_functions.h:93
+
+#define __device__ __attribute__((device))
+
----------------
JonChesterfield wrote:
> i think this should be `#define __device__`
Right because we already have `declare variant`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104904/new/

https://reviews.llvm.org/D104904