[PATCH] D104883: [CodeGen] Add ParmVarDecls to FunctionDecls that are created to generate ObjC property getter/setter functions

[David Blaikie via Phabricator via cfe-commits]

dblaikie added a comment.

In D104883#2841931 <https://reviews.llvm.org/D104883#2841931>, @ahatanak wrote:

> I see `assert(DC && "This decl is not contained in a translation unit!");` fail in `Decl::getTranslationUnitDecl` when `DeclRefExpr` is constructed. That's because the `ImplicitParamDecl` passed to `DeclRefExpr`'s constructor doesn't have a decl context if I delete `FD`. So it looks like `FD` is needed in these cases.

Hmm, OK - I think I'm following enough. I'll leave the rest to you & @aprantl - appreciate the work!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104883/new/

https://reviews.llvm.org/D104883