[PATCH] D104871: [Docs] use -fprofile-generate for IR PGO and -fprofile-instr-generate for code coverage

[David Li via Phabricator via cfe-commits]

davidxl added inline comments.


================
Comment at: clang/docs/UsersManual.rst:1881
    conversion tool that can convert one to the other. So, a profile generated
-   via ``-fprofile-instr-generate`` must be used with ``-fprofile-instr-use``.
+   via ``-fprofile-generate`` must be used with ``-fprofile-instr-use``.
    Similarly, sampling profiles generated by external profilers must be
----------------
This is not correct.   As of today,  -fprofile-use can be used with both -fprofile-generate and -fprofile-instr-generate. It does this by looking at the flag in the profile data.

The better way to document:

For profile guided optimizations, we recommend using IRPGO, aka  using-fprofile-generate with -fprofile-use


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104871/new/

https://reviews.llvm.org/D104871