[PATCH] D104904: [OpenMP][AMDGCN] Initial math headers support

[Siu Chi Chan via Phabricator via cfe-commits]

scchan added inline comments.


================
Comment at: clang/lib/Headers/__clang_hip_cmath.h:29
+#ifdef __OPENMP_AMDGCN__
+#define __DEVICE__ static constexpr __attribute__((always_inline, nothrow))
+#define __constant__ __attribute__((constant))
----------------
`__DEVICE__` should not imply constexpr.  It should be added to each function separately.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104904/new/

https://reviews.llvm.org/D104904