[PATCH] D75041: [clang-tidy] Extend 'bugprone-easily-swappable-parameters' with mixability because of implicit conversions

Fri Jun 25 05:45:32 PDT 2021

whisperity added inline comments.

================
Comment at: clang-tools-extra/clang-tidy/bugprone/EasilySwappableParametersCheck.cpp:249
+  /// the conversion sequence. This method does **NOT** return Begin and End.
+  SmallVector<QualType, 4> getInvolvedTypesInSequence() const {
+    SmallVector<QualType, 4> Ret;
----------------
aaron.ballman wrote:
> Return a `SmallVectorImpl<QualType>` so that the size of the vector doesn't matter to callers?
Meh... that seems to only work if the context is polymorphic, like reference parameters or pointers... This tries to return by value and construct, which is not possible for `Impl`.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75041/new/

https://reviews.llvm.org/D75041