[PATCH] D104505: [HIP] Defer operator overloading errors

[Rainer Orth via Phabricator via cfe-commits]

ro added a comment.

This patch broke the Solaris/sparcv9 <https://lab.llvm.org/staging/#/builders/50/builds/3824> and Solaris/amd64 <https://lab.llvm.org/staging/#/builders/101/builds/2552> buildbots:

  /opt/llvm-buildbot/home/solaris11-amd64/clang-solaris11-amd64/llvm/clang/include/clang/Sema/Sema.h:1782:11: error: non-const lvalue reference to type 'clang::Sema' cannot bind to a temporary of type 'int'
          : S(_S), SavedDeferDiags(S.DeferDiags) {
            ^ ~~
  /opt/llvm-buildbot/home/solaris11-amd64/clang-solaris11-amd64/llvm/clang/include/clang/Sema/Sema.h:1782:34: warning: reference 'S' is not yet bound to a value when used here [-Wuninitialized]
          : S(_S), SavedDeferDiags(S.DeferDiags) {
                                   ^
  /opt/llvm-buildbot/home/solaris11-amd64/clang-solaris11-amd64/llvm/clang/include/clang/Sema/Sema.h:1783:22: error: use of non-static data member 'DeferDiags' of 'Sema' from nested type 'DeferDiagsRAII'
        S.DeferDiags = DeferDiags;
                       ^~~~~~~~~~
  1 warning and 3 errors generated.
  [173/835] Building CXX object tools/clang/lib/Parse/CMakeFiles/obj.clangParse.dir/ParseDeclCXX.cpp.o
  FAILED: tools/clang/lib/Parse/CMakeFiles/obj.clangParse.dir/ParseDeclCXX.cpp.o 
  /opt/llvm/12/bin/clang++  -DCLANG_ROUND_TRIP_CC1_ARGS=ON -DGTEST_HAS_RTTI=0 -D_DEBUG -D_FILE_OFFSET_BITS=64 -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -Itools/clang/lib/Parse -I/opt/llvm-buildbot/home/solaris11-amd64/clang-solaris11-amd64/llvm/clang/lib/Parse -I/opt/llvm-buildbot/home/solaris11-amd64/clang-solaris11-amd64/llvm/clang/include -Itools/clang/include -Iinclude -I/opt/llvm-buildbot/home/solaris11-amd64/clang-solaris11-amd64/llvm/llvm/include -I/opt/llvm-buildbot/home/solaris11-amd64/clang-solaris11-amd64/llvm/llvm/include/llvm/Support/Solaris -fPIC -fvisibility-inlines-hidden -Werror=date-time -Werror=unguarded-availability-new -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -pedantic -Wno-long-long -Wc++98-compat-extra-semi -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wsuggest-override -Wstring-conversion -Wmisleading-indentation -fdiagnostics-color -ffunction-sections -fdata-sections -fno-common -Woverloaded-virtual -Wno-nested-anon-types -O3 -DNDEBUG    -fno-exceptions -fno-rtti -UNDEBUG -std=c++14 -MD -MT tools/clang/lib/Parse/CMakeFiles/obj.clangParse.dir/ParseDeclCXX.cpp.o -MF tools/clang/lib/Parse/CMakeFiles/obj.clangParse.dir/ParseDeclCXX.cpp.o.d -o tools/clang/lib/Parse/CMakeFiles/obj.clangParse.dir/ParseDeclCXX.cpp.o -c /opt/llvm-buildbot/home/solaris11-amd64/clang-solaris11-amd64/llvm/clang/lib/Parse/ParseDeclCXX.cpp
  In file included from /opt/llvm-buildbot/home/solaris11-amd64/clang-solaris11-amd64/llvm/clang/lib/Parse/ParseDeclCXX.cpp:13:
  In file included from /opt/llvm-buildbot/home/solaris11-amd64/clang-solaris11-amd64/llvm/clang/include/clang/Parse/Parser.h:24:
  /opt/llvm-buildbot/home/solaris11-amd64/clang-solaris11-amd64/llvm/clang/include/clang/Sema/Sema.h:1781:26: error: expected ')'
      DeferDiagsRAII(Sema &_S, bool DeferDiags)
                           ^
  /usr/include/iso/ctype_iso.h:32:12: note: expanded from macro '_S'
  #define _S      0x00000008      /* Spacing character */
                  ^
  /opt/llvm-buildbot/home/solaris11-amd64/clang-solaris11-amd64/llvm/clang/include/clang/Sema/Sema.h:1781:19: note: to match this '('
      DeferDiagsRAII(Sema &_S, bool DeferDiags)
                    ^
  /opt/llvm-buildbot/home/solaris11-amd64/clang-solaris11-amd64/llvm/clang/include/clang/Sema/Sema.h:1782:11: error: non-const lvalue reference to type 'clang::Sema' cannot bind to a temporary of type 'int'
          : S(_S), SavedDeferDiags(S.DeferDiags) {
            ^ ~~
  /opt/llvm-buildbot/home/solaris11-amd64/clang-solaris11-amd64/llvm/clang/include/clang/Sema/Sema.h:1782:34: warning: reference 'S' is not yet bound to a value when used here [-Wuninitialized]
          : S(_S), SavedDeferDiags(S.DeferDiags) {
                                   ^
  /opt/llvm-buildbot/home/solaris11-amd64/clang-solaris11-amd64/llvm/clang/include/clang/Sema/Sema.h:1783:22: error: use of non-static data member 'DeferDiags' of 'Sema' from nested type 'DeferDiagsRAII'
        S.DeferDiags = DeferDiags;
                       ^~~~~~~~~~
  1 warning and 3 errors generated.

`_S` is a reserved identifier in `<ctype.h>`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104505/new/

https://reviews.llvm.org/D104505