[PATCH] D103440: [WIP][analyzer] Introduce range-based reasoning for addition operator

Manas Gupta via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Jun 25 00:00:01 PDT 2021


manas added inline comments.


================
Comment at: clang/test/Analysis/constant-folding.c:330
+    clang_analyzer_eval((c + d) == INT_MAX - 22); // expected-warning{{FALSE}}
+  }
+}
----------------
vsavchenko wrote:
> manas wrote:
> > vsavchenko wrote:
> > > I don't see the cases where we overflow on both ends and the case where we overflow on one end, but `Min > Max`.
> > My bad. I thought I added both overflows one. I will add them now.
> This comment is marked as "Done", but I still don't these cases.
Amended. From line 260 and later.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103440/new/

https://reviews.llvm.org/D103440



More information about the cfe-commits mailing list