[PATCH] D104892: [clang] Stop providing builtin overload candidate for relational function pointer comparisons
Richard Smith - zygoloid via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Thu Jun 24 21:25:55 PDT 2021
rsmith added a comment.
Thanks, the summary gave me a chuckle :)
================
Comment at: clang/lib/Sema/SemaExpr.cpp:11809-11812
+ Diag(Loc, IsError
+ ? diag::err_typecheck_ordered_comparison_of_function_pointers
+ : diag::ext_typecheck_ordered_comparison_of_function_pointers)
+ << LHSType << RHSType << LHS.get()->getSourceRange()
----------------
In C++, non-`IsError` cases, this should be a `warn_...` diagnostic that is a `Warning<...>`, rather than an `ext_...` diagnostic that is an `ExtWarn<...>`, otherwise we'll reject this in `-pedantic-errors` mode. (That's what's happening in `test/CXX/drs/dr15xx.cpp`.)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D104892/new/
https://reviews.llvm.org/D104892
More information about the cfe-commits
mailing list