[PATCH] D104883: [CodeGen] Add ParmVarDecls to FunctionDecls that are created to generate ObjC property getter/setter functions

David Blaikie via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Jun 24 17:06:41 PDT 2021


dblaikie added a comment.

Ah - this is an alternative to D104082 <https://reviews.llvm.org/D104082>? OK. Yeah, looks like it'd address the thing we were discussing in D98799 <https://reviews.llvm.org/D98799>. But do you have some more details on why D104082 <https://reviews.llvm.org/D104082> wasn't the right direction? I thought we found other places that used a default-constructed/null `GlobalDecl()` for StartFunction` correctly, so I'm wondering why this would be a problem in this particular case(s)?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104883/new/

https://reviews.llvm.org/D104883



More information about the cfe-commits mailing list