[PATCH] D104831: [clang] Add x86_64-redhat-linux-gnu as a platform triplet

Thu Jun 24 09:41:05 PDT 2021

MaskRay added a comment.

In D104831#2838835 <https://reviews.llvm.org/D104831#2838835>, @hoy wrote:

> In D104831#2837712 <https://reviews.llvm.org/D104831#2837712>, @MaskRay wrote:
>
>>> Adding the platform tripplet x86_64-redhat-linux-gnu the while list of supported x86_64 triplets so that it can be used with the --gcc-toolchain option to bypass this process and force-pick a given gcc install.
>>
>> Did you set `--target=x86_64-redhat-linux-gnu`? With that I don't think you need another entry in `X86_64Triples`.
>>
>> `X86_64Triples` and its friends are quite clumsy and many entries are not actually needed. We should shrink the lists.
>>
>> For https://bugzilla.redhat.com/show_bug.cgi?id=1824365 I think the right fix is to configure clang with x86_64-redhat-linux-gnu as the default triple.
>
> Explicitly specifying target or configure the default build target would work. But I thought  the triple vector being updated is designed for automatic searching and minimizing configure changes across platforms. Is it not like that?

I am not sure about this guarantee. The list could be endless long if we supported every platform.

The right fix is to configure llvm-project with a correct `LLVM_DEFAULT_TARGET_TRIPLE`.

> In D104831#2837795 <https://reviews.llvm.org/D104831#2837795>, @tstellar wrote:
>
>> I'm curious, what kind of system are you running on where you need to use --gcc-toolchain x86_64-redhat-linux-gnu is required.
>
> One of our platforms is CentOS 7.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104831/new/

https://reviews.llvm.org/D104831