[PATCH] D104854: Introduce intrinsic llvm.isnan

Johannes Doerfert via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Jun 24 07:55:41 PDT 2021


jdoerfert added a comment.

In D104854#2838495 <https://reviews.llvm.org/D104854#2838495>, @sepavloff wrote:

> In D104854#2838468 <https://reviews.llvm.org/D104854#2838468>, @thopre wrote:
>
>> Are you planning to do this for the other FP test builtin (isinf, isfinite, isinf_sign, isnormal)?
>
> Yes, they have similar problems. 
> If someone would like to implement them it would be nice.

>From a user perspective, it seems sub-optimal to postpone the others "untile someone wants to implement them".
Once `isnan` behaves differently than the rest, I can see users being confused and rightfully so.
I don't have a strong opinion but I'd prefer we switch them over together.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104854/new/

https://reviews.llvm.org/D104854



More information about the cfe-commits mailing list