[PATCH] D104198: [Matrix] Add documentation for compound assignment and type conversion of matrix types

[Florian Hahn via Phabricator via cfe-commits]

fhahn added a comment.

Thanks for the latest changes!



================
Comment at: clang/docs/LanguageExtensions.rst:526
 
+The matrix type extension also supports operations between a matrix and a scalar.
+
----------------
I'm not a native speaker, but I am not sure if `between` is the best choice here. To me, `on` would sound slightly better, but again, I'm no expert.


================
Comment at: clang/docs/LanguageExtensions.rst:533
+  m4x4_t f(m4x4_t a) {
+      return (a + 23) * 12;
+  }
----------------
nit: only indent 2 spaces, like the others.


================
Comment at: clang/docs/LanguageExtensions.rst:562
+
+The matrix type extension supports explicit casts. The casts we support are C-style casts in C and C++ and
+static casts. Implicit type conversion between matrix types is not allowed.
----------------
Maybe just say that explicit conversions are supported, without going into the specific types of casts?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104198/new/

https://reviews.llvm.org/D104198