[PATCH] D103314: [Analyzer][solver] Simplify existing constraints when a new constraint is added

Thu Jun 24 02:37:00 PDT 2021

vsavchenko added a comment.

In D103314#2838065 <https://reviews.llvm.org/D103314#2838065>, @martong wrote:

> In D103314#2837907 <https://reviews.llvm.org/D103314#2837907>, @uabelho wrote:
>
>> Hi,
>>
>> Another failed assertion that started appearing with this patch:
>>
>>   clang --analyze bbi-57589.c
>>
>> which results in:
>>
>>   clang: ../lib/Support/APInt.cpp:284: int llvm::APInt::compareSigned(const llvm::APInt &) const: Assertion `BitWidth == RHS.BitWidth && "Bit widths must be same for comparison"' failed.
>>
>> F17570813: bbi-57589.c <https://reviews.llvm.org/F17570813>
>> Maybe it's the same root problem, but please make sure you fix both.
>> Thanks!
>
> Thanks again Mikael for the report. I could find the root cause and I have a solution that solves the assertions (both test cases are fixed). I am going to upload the fix soon.

Great!  Ping me when it's on review, I'll try to look into it ASAP!

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103314/new/

https://reviews.llvm.org/D103314