[PATCH] D104556: [InstrProfiling] Make CountersPtr in __profd_ relative

Wed Jun 23 14:05:07 PDT 2021

mstorsjo added a comment.

In D104556#2837104 <https://reviews.llvm.org/D104556#2837104>, @rnk wrote:

> In D104556#2837006 <https://reviews.llvm.org/D104556#2837006>, @MaskRay wrote:
>
>> Is it possible to ask MSVC to add the 64-bit `IMAGE_REL_AMD64_REL64` and `IMAGE_REL_ARM64_REL64`?
>> Newer compiler metadata techniques can benefit from using the same mechanism for all three major binary formats (PE-COFF/ELF/Mach-O).
>
> Swift wanted the same thing, so I think the answer is yes, we should ask.

What would the benefit of that be, as the difference itself can only ever be 32 bit? Is it only for consistency with other binary formats? I guess getting the value sign extended to a 64 bit value is a bit useful too.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104556/new/

https://reviews.llvm.org/D104556