[PATCH] D104388: [clang-format] PR50727 C# Invoke Lamda Expression indentation incorrect

MyDeveloperDay via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Jun 23 12:59:16 PDT 2021


MyDeveloperDay added a comment.

`lock` and `using` will be considered identifiers where as if and while will be seens as if/while

M=0 C=1 T=Unknown S=1 F=0 B=0 BK=0 P=99 Name=identifier L=66 PPK=2 FakeLParens= FakeRParens=0 II=0x1fdc7a0 Text='lock'

>From what I can tell they will be handled by the parsing parseIfElse etc.. what this tends to do is to jump from `{` to matching `}` which means it doesn't have to parse whats inside

This is why by detecting the => then parsing the `{` -> `}` of the lamdba as just and ordinary block.

I'm not 100% sure of the indentiation, I was assuming clang-format was just doing its thing...to be honest in its current form clang-format is devastating the files I'm looking at.. any level of indentation is better than what I'm getting

Ultimately we probably need to see how it interacts with D102706: [clang-format] Add new LambdaBodyIndentation option <https://reviews.llvm.org/D102706>


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104388/new/

https://reviews.llvm.org/D104388



More information about the cfe-commits mailing list