[PATCH] D104388: [clang-format] PR50727 C# Invoke Lamda Expression indentation incorrect

Björn Schäpers via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Jun 23 11:35:15 PDT 2021


HazardyKnusperkeks added a comment.

I have basically no idea about C#, thus not much to say. I think if the old tests pass and the new are as expected it is good.



================
Comment at: clang/unittests/Format/FormatTestCSharp.cpp:647
+               "    Function(Val, (Action)(() => {\n"
+               "                 lock (mylock)\n"
+               "                 {\n"
----------------
How is that indention calculated? Is this position fix? Or is it always one column less than the (presumably) start of the lambda?

Maybe add a test not with `Val`, but something else as first argument. Or is this not valid?

As said, basically no idea about C#.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104388/new/

https://reviews.llvm.org/D104388



More information about the cfe-commits mailing list