[PATCH] D104797: [WebAssembly] Implementation of global.get/set for reftypes in LLVM IR

Wed Jun 23 10:43:22 PDT 2021

pmatos added a comment.

This patch would have fixed the problems with AArch64 caused by D95425 <https://reviews.llvm.org/D95425>. However, since that was landed and reverted, this landed: https://github.com/llvm/llvm-project/commit/ac81cb7e6dde9b0890ee1780eae94ab96743569b

This breaks the test `llvm/test/CodeGen/WebAssembly/externref-ptrtoint.ll` which was expected to fail. I still think that a `ptrtoint` on an `externref` value should fail, and yet since `ac81cb7e` allows `ptrtoint` on non-integral pointer types, the verifier is letting this test to go through and it crashes LLVM later on during some DAG node analysis.

@tlively Do you think it would be ok to re-add the code removed in `ac81cb7e` but only error if the pointer is to an **opaque** non-integral type?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104797/new/

https://reviews.llvm.org/D104797