[PATCH] D104770: Add support for #pragma system_header with -fms-extensions

Hans Wennborg via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Jun 23 04:31:01 PDT 2021


hans added a comment.

In D104770#2835596 <https://reviews.llvm.org/D104770#2835596>, @aaron.ballman wrote:

> LGTM, though you could add a test that `#pragma system_header` gives a diagnostic outside of `-fms-extensions` mode if you think that's valuable.

Thanks! Yes, I'll do that, and I'll also add a test to see that it actually warns when no system_header is used.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104770/new/

https://reviews.llvm.org/D104770



More information about the cfe-commits mailing list