[PATCH] D102094: [AIX][PowerPC] Remove error when specifying mabi=vec-default on AIX

[Jinsong Ji via Phabricator via cfe-commits]

jsji accepted this revision as: jsji.
jsji added a comment.
This revision is now accepted and ready to land.

LGTM.



================
Comment at: clang/test/Driver/aix-vec-extabi.c:12
+/
+// NOEXTABI-NOT: "-mabi=vec-extabi"
 
----------------
Why not use `--implicit-check-not`?


================
Comment at: clang/test/Driver/aix-vec-extabi.c:3
+// RUN:  FileCheck %s --check-prefix=EXTABI
 // RUN:  %clang -### -target powerpc-unknown-aix -S -maltivec -mabi=vec-default %s 2>&1 | \
+// RUN:  FileCheck %s --check-prefix=DFLTABI
----------------
ZarkoCA wrote:
> jsji wrote:
> > How about RUN line without `-mabi`? 
> > and without `-maltivec`?
> > and `-mabi=vec-extabi` without `-maltivec`?
> Thanks, added those. Since `-mabi-vec-extabi` is a codegen option I think it makes sense to make sure it's not active when only `-maltivec` or nothing is specified on the command line. Does that work? 
I think you meant `-vec-extabi` option for llc? So maybe `--implicit-check-not=vec-extabi` should be better -- cover both mabi= and llc option.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102094/new/

https://reviews.llvm.org/D102094