[PATCH] D102094: [AIX][PowerPC] Remove error when specifying mabi=vec-default on AIX

Zarko Todorovski via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Jun 22 11:12:06 PDT 2021


ZarkoCA marked 2 inline comments as done.
ZarkoCA added inline comments.


================
Comment at: clang/lib/Driver/ToolChains/Clang.cpp:4779
       CmdArgs.push_back("-mabi=vec-extabi");
+    else if (A->getOption().getID() == options::OPT_mabi_EQ_vec_default)
+      CmdArgs.push_back("-mabi=vec-default");
----------------
jsji wrote:
> Why we need to check this if the default is to set it to `-mabi=vec-default` in below else?
I think my reasoning was to map `-mabi=vec-default` to something specific but we don't need it. 


================
Comment at: clang/test/Driver/aix-vec-extabi.c:11
+// DFLTABI-SAME: "-mabi=vec-default"
+// DFLTABI-NOT:  "-mabi=vec-default"
----------------
jsji wrote:
> Why we need to explicitly `DFLTABI-NOT:  "-mabi=vec-default"`
It's not required, removed. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102094/new/

https://reviews.llvm.org/D102094



More information about the cfe-commits mailing list