[PATCH] D102507: [HIP] Support <functional> in device code

Louis Dionne via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Jun 22 09:56:18 PDT 2021


ldionne added a comment.

In D102507#2830688 <https://reviews.llvm.org/D102507#2830688>, @yaxunl wrote:

> In D102507#2792087 <https://reviews.llvm.org/D102507#2792087>, @rsmith wrote:
>
>> @ldionne How should we go about establishing whether libc++ would be prepared to officially support CUDA? Right now, Clang's CUDA support is patching in attributes onto libc++ functions from the outside, which doesn't seem like a sustainable model.
>
> ping

If the current approach is to patch libc++ from the outside, then yeah, that's most definitely not a great design IMO. It's going to be very brittle. I think it *may* be reasonable to support this in libc++, but I'd like to see some sort of basic explanation of what the changes would be so we can have a discussion and make our mind up about whether we can support this, and what's the best way of doing it.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102507/new/

https://reviews.llvm.org/D102507



More information about the cfe-commits mailing list