[PATCH] D104619: [clang] [WIP] Fix for https://bugs.llvm.org/show_bug.cgi?id=50774

Mon Jun 21 17:55:20 PDT 2021

nridge added a comment.

Thanks for having a look!

In D104619#2831953 <https://reviews.llvm.org/D104619#2831953>, @dblaikie wrote:

> This'll need a test case

Definitely. Do you have a suggestion for what test suite that should go into? I had a quick look but couldn't find anything that obviously exercised `TypePrinter`.

> & does the change pass all existing tests?

I mainly pushed the patch to Phabricator in this WIP form because I was hoping that would trigger some sort of CI run that would tell me that :) (I tried running `ninja check-clang` locally, but that was looking to take a very long time (like 2+ hours) to run locally.)

It's not clear to me if that actually happened? I see something about "pre-merge checks" in the revision metadata, but it's not clear to me what test suites it actually ran.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104619/new/

https://reviews.llvm.org/D104619