[PATCH] D104656: Reland "[AArch64] handle -Wa,-march="

Jian Cai via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Jun 21 11:17:56 PDT 2021


jcai19 updated this revision to Diff 353431.
jcai19 added a comment.

Add comments explaning the difference with D103184 <https://reviews.llvm.org/D103184>. The implementation in D103184 <https://reviews.llvm.org/D103184> unconditionally calls getAArch64ArchFeaturesFromMarch, which returns false when an irrelevant -Wa value is detected and parsed (e.g. -Wa,--version) and causes Clang to bail out.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104656/new/

https://reviews.llvm.org/D104656

Files:
  clang/lib/Driver/ToolChains/Arch/AArch64.cpp
  clang/lib/Driver/ToolChains/Arch/AArch64.h
  clang/lib/Driver/ToolChains/Clang.cpp
  clang/test/Driver/aarch64-target-as-march.s

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D104656.353431.patch
Type: text/x-patch
Size: 5541 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20210621/07a262ba/attachment-0001.bin>


More information about the cfe-commits mailing list