[PATCH] D94333: [Inliner] Change inline remark format and update ReplayInlineAdvisor to use it

Sat Jun 19 12:55:03 PDT 2021

sylvestre.ledru added a comment.
Herald added a subscriber: ormris.

I think this change broke apt.llvm.org

  > [100%] Linking CXX shared library ../../lib/libLLVM-13.so
  > cd "/build/llvm-toolchain-snapshot-13~++20210619083511+1605fce6c307/build-llvm/tools/llvm-shlib" && /usr/bin/cmake -E cmake_link_script CMakeFiles/LLVM.dir/link.txt --verbose=1
  > /usr/lib/ccache/g++-10 -fPIC -g -O2 -fdebug-prefix-map=/build/llvm-toolchain-snapshot-13~++20210619083511+1605fce6c307=. -fstack-protector-strong -Wformat -Werror=format-security -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wno-missing-field-initializers -pedantic -Wno-long-long -Wimplicit-fallthrough -Wno-maybe-uninitialized -Wno-class-memaccess -Wno-redundant-move -Wno-pessimizing-move -Wno-noexcept-type -Wdelete-non-virtual-dtor -Wsuggest-override -Wno-comment -Wmisleading-indentation -ffunction-sections -fdata-sections -O2 -DNDEBUG -g1  -Wl,-rpath-link,/build/llvm-toolchain-snapshot-13~++20210619083511+1605fce6c307/build-llvm/./lib  -Wl,-O3 -Wl,--gc-sections -Wl,-Bsymbolic-functions -Wl,-Bsymbolic-functions -Wl,-z,relro -Wl,-z,defs -Wl,-z,nodelete -shared -Wl,-soname,libLLVM-13.so.1 -o ../../lib/libLLVM-13.so.1 CMakeFiles/LLVM.dir/libllvm.cpp.o  -Wl,-rpath,"\$ORIGIN/../lib" -Wl,--version-script,/build/llvm-toolchain-snapshot-13~++20210619083511+1605fce6c307/build-llvm/./lib/tools/llvm-shlib/simple_version_script.map -Wl,--whole-archive ../../lib/libLLVMDemangle.a ../../lib/libLLVMSupport.a ../../lib/libLLVMCore.a ../../lib/libLLVMFuzzMutate.a ../../lib/libLLVMFileCheck.a ../../lib/libLLVMInterfaceStub.a ../../lib/libLLVMIRReader.a ../../lib/libLLVMCodeGen.a ../../lib/libLLVMSelectionDAG.a ../../lib/libLLVMAsmPrinter.a ../../lib/libLLVMMIRParser.a ../../lib/libLLVMGlobalISel.a ../../lib/libLLVMBinaryFormat.a ../../lib/libLLVMBitReader.a ../../lib/libLLVMBitWriter.a ../../lib/libLLVMBitstreamReader.a ../../lib/libLLVMDWARFLinker.a ../../lib/libLLVMExtensions.a ../../lib/libLLVMFrontendOpenACC.a ../../lib/libLLVMFrontendOpenMP.a ../../lib/libLLVMTransformUtils.a ../../lib/libLLVMInstrumentation.a ../../lib/libLLVMAggressiveInstCombine.a ../../lib/libLLVMInstCombine.a ../../lib/libLLVMScalarOpts.a ../../lib/libLLVMipo.a ../../lib/libLLVMVectorize.a ../../lib/libLLVMObjCARCOpts.a ../../lib/libLLVMCoroutines.a ../../lib/libLLVMCFGuard.a ../../lib/libLLVMLinker.a ../../lib/libLLVMAnalysis.a ../../lib/libLLVMLTO.a ../../lib/libLLVMMC.a ../../lib/libLLVMMCParser.a ../../lib/libLLVMMCDisassembler.a ../../lib/libLLVMMCA.a ../../lib/libLLVMObject.a ../../lib/libLLVMObjectYAML.a ../../lib/libLLVMOption.a ../../lib/libLLVMRemarks.a ../../lib/libLLVMDebugInfoDWARF.a ../../lib/libLLVMDebugInfoGSYM.a ../../lib/libLLVMDebugInfoMSF.a ../../lib/libLLVMDebugInfoCodeView.a ../../lib/libLLVMDebugInfoPDB.a ../../lib/libLLVMSymbolize.a ../../lib/libLLVMExecutionEngine.a ../../lib/libLLVMInterpreter.a ../../lib/libLLVMJITLink.a ../../lib/libLLVMMCJIT.a ../../lib/libLLVMOrcJIT.a ../../lib/libLLVMOrcShared.a ../../lib/libLLVMOrcTargetProcess.a ../../lib/libLLVMRuntimeDyld.a ../../lib/libLLVMPerfJITEvents.a ../../lib/libLLVMTarget.a ../../lib/libLLVMAArch64CodeGen.a ../../lib/libLLVMAArch64AsmParser.a ../../lib/libLLVMAArch64Disassembler.a ../../lib/libLLVMAArch64Desc.a ../../lib/libLLVMAArch64Info.a ../../lib/libLLVMAArch64Utils.a ../../lib/libLLVMAMDGPUCodeGen.a ../../lib/libLLVMAMDGPUAsmParser.a ../../lib/libLLVMAMDGPUDisassembler.a ../../lib/libLLVMAMDGPUDesc.a ../../lib/libLLVMAMDGPUInfo.a ../../lib/libLLVMAMDGPUUtils.a ../../lib/libLLVMARMCodeGen.a ../../lib/libLLVMARMAsmParser.a ../../lib/libLLVMARMDisassembler.a ../../lib/libLLVMARMDesc.a ../../lib/libLLVMARMInfo.a ../../lib/libLLVMARMUtils.a ../../lib/libLLVMAVRCodeGen.a ../../lib/libLLVMAVRAsmParser.a ../../lib/libLLVMAVRDisassembler.a ../../lib/libLLVMAVRDesc.a ../../lib/libLLVMAVRInfo.a ../../lib/libLLVMBPFCodeGen.a ../../lib/libLLVMBPFAsmParser.a ../../lib/libLLVMBPFDisassembler.a ../../lib/libLLVMBPFDesc.a ../../lib/libLLVMBPFInfo.a ../../lib/libLLVMHexagonCodeGen.a ../../lib/libLLVMHexagonAsmParser.a ../../lib/libLLVMHexagonDisassembler.a ../../lib/libLLVMHexagonDesc.a ../../lib/libLLVMHexagonInfo.a ../../lib/libLLVMLanaiCodeGen.a ../../lib/libLLVMLanaiAsmParser.a ../../lib/libLLVMLanaiDisassembler.a ../../lib/libLLVMLanaiDesc.a ../../lib/libLLVMLanaiInfo.a ../../lib/libLLVMMipsCodeGen.a ../../lib/libLLVMMipsAsmParser.a ../../lib/libLLVMMipsDisassembler.a ../../lib/libLLVMMipsDesc.a ../../lib/libLLVMMipsInfo.a ../../lib/libLLVMMSP430CodeGen.a ../../lib/libLLVMMSP430Desc.a ../../lib/libLLVMMSP430Info.a ../../lib/libLLVMMSP430AsmParser.a ../../lib/libLLVMMSP430Disassembler.a ../../lib/libLLVMNVPTXCodeGen.a ../../lib/libLLVMNVPTXDesc.a ../../lib/libLLVMNVPTXInfo.a ../../lib/libLLVMPowerPCCodeGen.a ../../lib/libLLVMPowerPCAsmParser.a ../../lib/libLLVMPowerPCDisassembler.a ../../lib/libLLVMPowerPCDesc.a ../../lib/libLLVMPowerPCInfo.a ../../lib/libLLVMRISCVCodeGen.a ../../lib/libLLVMRISCVAsmParser.a ../../lib/libLLVMRISCVDisassembler.a ../../lib/libLLVMRISCVDesc.a ../../lib/libLLVMRISCVInfo.a ../../lib/libLLVMSparcCodeGen.a ../../lib/libLLVMSparcAsmParser.a ../../lib/libLLVMSparcDisassembler.a ../../lib/libLLVMSparcDesc.a ../../lib/libLLVMSparcInfo.a ../../lib/libLLVMSystemZCodeGen.a ../../lib/libLLVMSystemZAsmParser.a ../../lib/libLLVMSystemZDisassembler.a ../../lib/libLLVMSystemZDesc.a ../../lib/libLLVMSystemZInfo.a ../../lib/libLLVMWebAssemblyCodeGen.a ../../lib/libLLVMWebAssemblyAsmParser.a ../../lib/libLLVMWebAssemblyDisassembler.a ../../lib/libLLVMWebAssemblyDesc.a ../../lib/libLLVMWebAssemblyInfo.a ../../lib/libLLVMWebAssemblyUtils.a ../../lib/libLLVMX86CodeGen.a ../../lib/libLLVMX86AsmParser.a ../../lib/libLLVMX86Disassembler.a ../../lib/libLLVMX86Desc.a ../../lib/libLLVMX86Info.a ../../lib/libLLVMXCoreCodeGen.a ../../lib/libLLVMXCoreDisassembler.a ../../lib/libLLVMXCoreDesc.a ../../lib/libLLVMXCoreInfo.a ../../lib/libLLVMM68kCodeGen.a ../../lib/libLLVMM68kInfo.a ../../lib/libLLVMM68kDesc.a ../../lib/libLLVMM68kAsmParser.a ../../lib/libLLVMM68kDisassembler.a ../../lib/libLLVMAsmParser.a ../../lib/libLLVMLineEditor.a ../../lib/libLLVMProfileData.a ../../lib/libLLVMCoverage.a ../../lib/libLLVMPasses.a ../../lib/libLLVMTextAPI.a ../../lib/libLLVMDlltoolDriver.a ../../lib/libLLVMLibDriver.a ../../lib/libLLVMXRay.a ../../lib/libLLVMWindowsManifest.a -Wl,--no-whole-archive ../../lib/libLLVMExtensions.a ../../lib/libPolly.a ../../lib/libPollyISL.a ../../lib/libLLVMDebugInfoPDB.a /usr/lib/s390x-linux-gnu/libffi.so ../../lib/libLLVMJITLink.a ../../lib/libLLVMExecutionEngine.a ../../lib/libLLVMOrcTargetProcess.a ../../lib/libLLVMOrcShared.a ../../lib/libLLVMRuntimeDyld.a ../../lib/libLLVMMIRParser.a ../../lib/libLLVMPasses.a ../../lib/libLLVMObjCARCOpts.a ../../lib/libLLVMCoroutines.a ../../lib/libLLVMMSP430Desc.a ../../lib/libLLVMMSP430Info.a ../../lib/libLLVMipo.a ../../lib/libLLVMIRReader.a ../../lib/libLLVMAsmParser.a ../../lib/libLLVMFrontendOpenMP.a ../../lib/libLLVMInstrumentation.a ../../lib/libLLVMLinker.a ../../lib/libLLVMVectorize.a ../../lib/libLLVMCFGuard.a ../../lib/libLLVMM68kCodeGen.a ../../lib/libLLVMAsmPrinter.a ../../lib/libLLVMDebugInfoDWARF.a ../../lib/libLLVMDebugInfoMSF.a ../../lib/libLLVMGlobalISel.a ../../lib/libLLVMSelectionDAG.a ../../lib/libLLVMCodeGen.a ../../lib/libLLVMBitWriter.a ../../lib/libLLVMScalarOpts.a ../../lib/libLLVMAggressiveInstCombine.a ../../lib/libLLVMInstCombine.a ../../lib/libLLVMTransformUtils.a ../../lib/libLLVMTarget.a ../../lib/libLLVMAnalysis.a ../../lib/libLLVMM68kDesc.a ../../lib/libLLVMMCDisassembler.a ../../lib/libLLVMM68kInfo.a -ledit ../../lib/libLLVMProfileData.a ../../lib/libLLVMOption.a ../../lib/libLLVMObject.a ../../lib/libLLVMBitReader.a ../../lib/libLLVMCore.a ../../lib/libLLVMRemarks.a ../../lib/libLLVMBitstreamReader.a ../../lib/libLLVMMCParser.a ../../lib/libLLVMMC.a ../../lib/libLLVMDebugInfoCodeView.a ../../lib/libLLVMTextAPI.a ../../lib/libLLVMBinaryFormat.a ../../lib/libLLVMSupport.a ../../lib/libLLVMDemangle.a -lrt -ldl -lpthread -lm /usr/lib/s390x-linux-gnu/libz.so /usr/lib/s390x-linux-gnu/libtinfo.so 
  > /usr/bin/ld: ../../lib/libLLVMM68kCodeGen.a(M68kSubtarget.cpp.o): in function `llvm::M68kGenRegisterBankInfo::M68kGenRegisterBankInfo()':
  > ./build-llvm/lib/Target/M68k/./llvm/include/llvm/ADT/SmallVector.h:580: multiple definition of `llvm::M68kGenRegisterBankInfo::M68kGenRegisterBankInfo()'; ../../lib/libLLVMM68kCodeGen.a(M68kRegisterBankInfo.cpp.o):./build-llvm/lib/Target/M68k/./build-llvm/lib/Target/M68k/M68kGenRegisterBank.inc:49: first defined here
  > /usr/bin/ld: ../../lib/libLLVMM68kCodeGen.a(M68kSubtarget.cpp.o): in function `llvm::M68kGenRegisterBankInfo::M68kGenRegisterBankInfo()':
  > ./build-llvm/lib/Target/M68k/./llvm/include/llvm/ADT/SmallVector.h:580: multiple definition of `llvm::M68kGenRegisterBankInfo::M68kGenRegisterBankInfo()'; ../../lib/libLLVMM68kCodeGen.a(M68kRegisterBankInfo.cpp.o):./build-llvm/lib/Target/M68k/./build-llvm/lib/Target/M68k/M68kGenRegisterBank.inc:49: first defined here
  > /usr/bin/ld: ../../lib/libLLVMM68kCodeGen.a(M68kSubtarget.cpp.o): in function `llvm::M68kRegisterBankInfo::M68kRegisterBankInfo(llvm::TargetRegisterInfo const&)':
  > ./build-llvm/lib/Target/M68k/./llvm/include/llvm/ADT/SmallVector.h:254: multiple definition of `llvm::M68kRegisterBankInfo::M68kRegisterBankInfo(llvm::TargetRegisterInfo const&)'; ../../lib/libLLVMM68kCodeGen.a(M68kRegisterBankInfo.cpp.o):./build-llvm/lib/Target/M68k/./llvm/lib/Target/M68k/GlSel/M68kRegisterBankInfo.cpp:26: first defined here
  > /usr/bin/ld: ../../lib/libLLVMM68kCodeGen.a(M68kSubtarget.cpp.o): in function `llvm::M68kRegisterBankInfo::M68kRegisterBankInfo(llvm::TargetRegisterInfo const&)':
  > ./build-llvm/lib/Target/M68k/./llvm/include/llvm/ADT/SmallVector.h:254: multiple definition of `llvm::M68kRegisterBankInfo::M68kRegisterBankInfo(llvm::TargetRegisterInfo const&)'; ../../lib/libLLVMM68kCodeGen.a(M68kRegisterBankInfo.cpp.o):./build-llvm/lib/Target/M68k/./llvm/lib/Target/M68k/GlSel/M68kRegisterBankInfo.cpp:26: first defined here
  > /usr/bin/ld: ../../lib/libLLVMM68kCodeGen.a(M68kSubtarget.cpp.o):(.data.rel.local._ZN4llvm23M68kGenRegisterBankInfo8RegBanksE+0x0): multiple definition of `llvm::M68kGenRegisterBankInfo::RegBanks'; ../../lib/libLLVMM68kCodeGen.a(M68kRegisterBankInfo.cpp.o):(.data.rel.local._ZN4llvm23M68kGenRegisterBankInfo8RegBanksE+0x0): first defined here
  > /usr/bin/ld: ../../lib/libLLVMM68kCodeGen.a(M68kSubtarget.cpp.o):(.bss._ZN4llvm4M68k10GPRRegBankE+0x0): multiple definition of `llvm::M68k::GPRRegBank'; ../../lib/libLLVMM68kCodeGen.a(M68kRegisterBankInfo.cpp.o):(.bss._ZN4llvm4M68k10GPRRegBankE+0x0): first defined here

Could you please have a look?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94333/new/

https://reviews.llvm.org/D94333