[PATCH] D104500: [clang] Apply P1825 as Defect Report for all C++ standards up to C++20.

[Matheus Izvekov via Phabricator via cfe-commits]

mizvekov added inline comments.


================
Comment at: clang/test/CXX/class/class.init/class.copy.elision/p3.cpp:58-60
 A1 test1(A1 &&a) {
-  return a; // cxx11_17-error {{call to deleted constructor of 'test_implicitly_movable_rvalue_ref::A1'}}
+  return a;
 }
----------------
mizvekov wrote:
> Quuxplusone wrote:
> > Personally, I don't think the world will accept applying P0527 unconditionally in pre-C++20 modes. But I guess we'll find out. :P
> Indeed :)
> By the way, I have not found a counter example of strict C++98 code (not using extensions) breaking with implicit moves enabled.
> So it looks like we can have one mode for everything here.
Oh never mind I was wrong :)

Found your example: https://godbolt.org/z/T374o518W

Too bad we had not put it in our test suite.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104500/new/

https://reviews.llvm.org/D104500