[PATCH] D104475: [Clang][Codegen] emit noprofile IR Fn Attr for new Fn Attr no_profile

[Aaron Ballman via Phabricator via cfe-commits]

aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.

LGTM!



================
Comment at: clang/include/clang/Basic/Attr.td:1975
+  let Spellings = [Clang<"no_profile">];
+  let Subjects = SubjectList<[Function]>;
+  let Documentation = [NoProfileDocs];
----------------
nickdesaulniers wrote:
> aaron.ballman wrote:
> > Should this also be supported on ObjC methods?
> Wouldn't that be the case for many surrounding attributes defined near by?  I don't see why not, but I also know literally nothing about ObjC.  Would you like me to extend this attribute to ObjC methods?
It would be, and I think many of them are in the same state for the same reason (not knowing about ObjC).

I don't insist on the change. I ask whenever I see `Function` in the subject list because it's pretty rare that ObjC methods work differently than a function call in ways that matter for attributes. We can always add the functionality when a user requests it, later.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104475/new/

https://reviews.llvm.org/D104475