[PATCH] D104540: [clangd] Dont index ObjCCategoryDecls for completion

David Goldman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Jun 18 08:35:33 PDT 2021


dgoldman added inline comments.


================
Comment at: clang-tools-extra/clangd/CodeComplete.cpp:1918
+  // from the index, we reduce the noise in all the other completion scopes.
+  if (llvm::isa<ObjCCategoryDecl>(&ND))
+    return false;
----------------
Seems like we should also ignore ObjCCategoryImplDecl, I think those would have the same issue (although only from other .m files in the project, not from SDK headers)?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104540/new/

https://reviews.llvm.org/D104540



More information about the cfe-commits mailing list