[PATCH] D88666: DirectoryWatcher: add an implementation for Windows

[Adrian McCarthy via Phabricator via cfe-commits]

amccarth added a comment.

In D88666#2825557 <https://reviews.llvm.org/D88666#2825557>, @stella.stamenova wrote:

> One thing we've run into in the past is that running some of these tests **on a drive other than the OS drive** can cause weird failure. I am not sure if that may be the case here as well.

As long as it's a local drive, that _shouldn't_ be a problem.  I always run tests on a different drive than the OS system drive.

If it's a network drive, then, yeah, that would likely be a problem.  If I recall correctly, ReadDirectoryChangesW has substantial limitations when pointed at a remote drive.  The implementation should probably check that and signal an "unsupported" error.

Also note that Stella's sample log looks slightly different than the failures we were reproducing.  It's almost as if the initial scan never finished.  I haven't looked at that code, but I wonder if the file iteration is stuck in some kind of loop due to links or mount points or something.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88666/new/

https://reviews.llvm.org/D88666