[PATCH] D103930: [clang][HeaderSearch] Fix implicit module when using header maps

[Duncan P. N. Exon Smith via Phabricator via cfe-commits]

dexonsmith added inline comments.


================
Comment at: clang/test/Modules/implicit-module-header-maps.cpp:27
+#define FOO
+// This include will fail if modules weren't used.  The include name itself
+// doesn't exist and relies on the header map to remap it to the real header.
----------------
andrewjcg wrote:
> andrewjcg wrote:
> > dexonsmith wrote:
> > > Do you really mean if modules aren't used, or do you mean if header maps aren't used?
> > > 
> > > (I think we want to find the same headers on disk whether or not modules are on... if this patch changes that, then I guess I'm not totally understanding why...)
> > Ahh, meant if header maps aren't used.  Will fix.
> Ah no wait.  The include should fail if either header maps or modules isn't used (header maps required for the remapping and modules required to prevent the `FOO` define from propagating into the included header and triggering the `#error`).  
> 
> Will update the comment.
Got it, thanks, the comment is clear now!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103930/new/

https://reviews.llvm.org/D103930