[PATCH] D104376: [clangd] Correct SelectionTree behavior around anonymous field access.
Haojian Wu via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Thu Jun 17 05:08:31 PDT 2021
hokein accepted this revision.
hokein added inline comments.
This revision is now accepted and ready to land.
================
Comment at: clang-tools-extra/clangd/Selection.cpp:71
+ // so we reduce its range to match the CXXConstructExpr.
+ // (It's not clear that changing the clang AST would be correct in general).
+ if (const auto *ME = N.get<MemberExpr>()) {
----------------
I still think it is worth to explore this direction (will take a look on this if I have time), but also ok with the current approach.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D104376/new/
https://reviews.llvm.org/D104376
More information about the cfe-commits
mailing list