[PATCH] D104198: [Matrix] Add documentation for compound assignment and type conversion of matrix types

Florian Hahn via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Jun 17 01:48:43 PDT 2021


fhahn added inline comments.


================
Comment at: clang/docs/LanguageExtensions.rst:535
+      int d = 12;
+      a = a + c;
+      return a * d;
----------------
Is there any reason we use variables for the scalars? If not, it might be good to keep the examples as compact as possible. Using the extra variables seems overly verbose, when it could be just `return (a + 23) * 12`  and may give the impression only scalar variables are supported.

same also applies to the other examples below.


================
Comment at: clang/docs/LanguageExtensions.rst:578
+    f = (fx5x5)i;
+    return f;
+  }
----------------
this could also just be `return (fx5x5) i;`, right?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104198/new/

https://reviews.llvm.org/D104198



More information about the cfe-commits mailing list